-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw when providing null or empty array to -ForEach #2537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflaten
changed the title
Throw when no Data passed to -ForEach
Throw when providing null or empty array to -ForEach
Jul 9, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
nohwnd
approved these changes
Jul 10, 2024
Amazing work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Throw during Discovery when
Describe/Context/It
is provided$null
or@()
to-ForEach/TestCases
to avoid silent failure.The previous behavior, ignoring the test/block, can be achieved by setting the configuration option
Run.FailOnNullOrEmptyForEach
to$false
.When enabled, individual blocks or tests can be overriden to allow empty array or null by adding a new
-AllowNullOrEmptyForEach
parameter toDescribe/Context/It
, e.g. if a test is generated using external data which might be empty.Fix #2151
PR Checklist
Create Pull Request
to mark it as a draft. PR can be markedReady for review
when it's ready.