-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FixStacktraceLanguage #2391
Closed
Closed
FixStacktraceLanguage #2391
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0bdea48
FixStacktraceLanguage
b2410c4
Fix exclude for StackTraceLanguage for POSH V3/4
ce24250
Enhanced Fallback for all Version and Support for POSH 3/4
59c9c93
Version 4 Error optimizing
086fddf
Reset to 27.09
19ca5e9
Merge branch 'FixStackTraceLanguageIssue' of https://github.com/Aktur…
4d0a432
Variabels corrected
8c25c0a
Revert to Commit from 27.09
f3d27b1
Merge branch 'main' into FixStackTraceLanguageIssue
nohwnd f352060
Parse words from exception
nohwnd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -59,6 +59,20 @@ $script:SessionStateInternalProperty = [System.Management.Automation.SessionStat | |||
$script:ScriptBlockSessionStateInternalProperty = [System.Management.Automation.ScriptBlock].GetProperty('SessionStateInternal', $flags) | ||||
$script:ScriptBlockSessionStateProperty = [System.Management.Automation.ScriptBlock].GetProperty("SessionState", $flags) | ||||
|
||||
function Get-StackTraceLanguage { | ||||
$err = try { throw "err" } catch { $_ } | ||||
$firstFrame = ($err.ScriptStackTrace -split [System.Environment]::NewLine, 2 )[0] | ||||
if ($firstFrame -match "(?<at>.[^G]?)\s+Get-StackTraceLanguage(?<separator>.).+:\s+(?<line>.\S+)\s\d+") { | ||||
@{ | ||||
At = $Matches["at"] | ||||
Separator = $Matches["separator"] | ||||
Line = $Matches["line"] | ||||
} | ||||
} | ||||
} | ||||
#defining script variable | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
$script:StackTraceLanguage = Get-StackTraceLanguage | ||||
|
||||
if (notDefined PesterPreference) { | ||||
$PesterPreference = [PesterConfiguration]::Default | ||||
} | ||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed your code to parse it from exception that we throw, as originally suggested. This should be cheaper and easier to replicate than relying on internal resource names because we rely on public api.