Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed TODO about removed box syntax #854

Merged
merged 1 commit into from
May 6, 2023
Merged

Removed TODO about removed box syntax #854

merged 1 commit into from
May 6, 2023

Conversation

Tartasprint
Copy link
Contributor

I removed the multiple TODO comments about Rust's box syntax, because it has been removed according to rust-lang/rust/pull/108471

@Tartasprint Tartasprint requested a review from a team as a code owner May 6, 2023 14:56
@Tartasprint Tartasprint requested review from tomtau and removed request for a team May 6, 2023 14:56
tomtau
tomtau approved these changes May 6, 2023
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, i didn't know it was removed. based on the discussion, those performance difference seem mainly around boxed array, so probably no need to worry about it here

@tomtau tomtau merged commit 23831ec into pest-parser:master May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomtau tomtau tomtau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tartasprint @tomtau