-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expansion error in pest-derive
with tags
#899
Labels
Comments
Possibly, that will resolve it from the crate root, so that should normally work with default features? |
Prepending the |
tomtau
pushed a commit
that referenced
this issue
Jul 24, 2023
The generator currently wraps tags in an instance of alloc::borrow::Cow. This PR changes that to std::borrow::Cow conditional on the std feature flag being active. Closes #899.
This was referenced Oct 2, 2023
flyingsilverfin
pushed a commit
to typedb/typedb-dependencies
that referenced
this issue
Oct 2, 2023
## What is the goal of this PR? We update to pest and pest-derive v2.7.4, which among other things purports to fix the error where [deriving Parser fails on "undeclared crate or module `alloc`"](pest-parser/pest#899) (pest-parser/pest#900).
flyingsilverfin
pushed a commit
to typedb/typeql
that referenced
this issue
Oct 2, 2023
## What is the goal of this PR? We update to pest and pest-derive v2.7.4, which among other things purports to fix the error where [deriving Parser fails on "undeclared crate or module `alloc`"](pest-parser/pest#899) (pest-parser/pest#900). ## What are the changes implemented in this PR? We also clean up some compile warnings (unused imports and hashes).
flyingsilverfin
pushed a commit
to typedb/typedb-driver
that referenced
this issue
Oct 2, 2023
## What is the goal of this PR? We update to pest and pest-derive v2.7.4, which among other things purports to fix the error where [deriving Parser fails on "undeclared crate or module `alloc`"](pest-parser/pest#899) (pest-parser/pest#900). ## What are the changes implemented in this PR? We also update README URLs and project descriptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
On Rust 1.70 and 1.71, when using tags, the derive macro errors out with the following:
To Reproduce
Here is a minimum reproducible example:
Expected behavior
The generated code should not emit the error.
Additional context
extern crate alloc
at the top oflib.rs
makes the error go away -- it is a feasible workaround, but it should probably not be asked of the users to do that.alloc
in the expanded code:::
so that we have::alloc
be a potential solution?Thank you for all your work on this library!
The text was updated successfully, but these errors were encountered: