Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1077 : Solve the bad route selection based on acceptType #1238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chauncey-Xxy
Copy link

Try to fix #1077
Because the #1224 request has some bugs, and I deleted the repository during the previous test, so close the previous request and pull the new request:

I am not sure whether it is a bug, because it is tagged as Bug ..?, but I think it conflict with the documentation, so I try to fix it.

In short, we expect the input with empty acceptType will match any possible types as follows:
curl -i -H "Accept: application/json" http://localhost:4567/hello : Hello application json
curl -i -H "Accept: text/html" http://localhost:4567/hello : Go Away!!!
curl http://localhost:4567/hello : Hello application json
Now the first and second are right, but the last command will get output: Go Away!!!
I think it is not reasonable because the empty acceptType should match every possibilities and use the earliest match principle, it should match the first possible acceptType.
So I change the codes to match "/" with the earliest acceptType.

Co-Authored-By: Bugjudger [email protected]

@lepe lepe mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad route selection based on acceptType.
1 participant