Making the code more idiomatic #20
Conversation
|
I'm back from vacation and will start reviewing this very soon! |
|
@perwendel |
|
@Guppster I would like to know if this issue will be updated as well... Much has changed since I wrote the code to this pull request. At the time I was also willing to help into another issues but since all the issues is out of date I've start to wonder if worth the effort of spending time trying to solve those issues. |
| import kotlin.reflect.KClass | ||
|
|
||
| // STATIC API BEGIN | ||
| val DEFAULT_ACCEPT = "*/*" | ||
| val DEFAULT_ACCEPT by lazy { "*/*" } |
There was a problem hiding this comment.
More over it brings contention on getter since lazy is thread safe.
|
I've been off track for a while for several reasons and I'm really trying to find the time to wrap up and make an official kotlin release. I know there have been changes so I will try to cherry-pick the goodies from this PR into the updated master branch. |
This is a general cleanup to make this DSL more Kotlin like. This pull request does not change the code dynamics but in some points does change the code structure in order to take advantege of the Kotlin language and to make the code shorter, cleaner and readable.