[FEATURE] standard ingress with TLS #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will replace ingress with helm standard ingress, which also adds support for TLS configuration. Recommended usage:
```yaml
ingress:
enabled: true
annotations:
kubernetes.io/tls-acme: "true"
hosts:
- perses.example.com
tls:
- secretName: ingress-cert
hosts:
- perses.example.com
```
in combination with [cert-manager](https://cert-manager.io/) this will automatically generate certificates and configure HTTPS.
Signed-off-by: Michael Sprauer <[email protected]>
|
@nicolastakashi would you mind to review this PR please ? I don't feel I have the knowledge to do it myself. |
|
Hey @MichaelSp thanks for your contribution, LGTM |
nicolastakashi
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will replace ingress with helm standard ingress, which also adds support for TLS configuration.
Recommended usage:
in combination with cert-manager this will automatically generate certificates and configure HTTPS.
Description
Checklist
[<catalog_entry>] <commit message>naming convention using one of the followingcatalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,IGNORE.