[BUGFIX] fix portName reference in ingress (#9)

Signed-off-by: Lucas <[email protected]>
perses · Sep 15, 2023 · 496af38 · 496af38
1 parent c68b739
commit 496af38
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 5 deletions.
diff --git a/charts/perses/Chart.yaml b/charts/perses/Chart.yaml
@@ -3,7 +3,7 @@ name: perses
 description: Perses helm chart
 icon: https://avatars.githubusercontent.com/u/77209215?s=200&v=4
 type: application
-version: 0.1.2
+version: 0.1.3
 appVersion: "0.39.0"
 sources:
   - https://github.com/perses/perses

diff --git a/charts/perses/README.md b/charts/perses/README.md
@@ -4,7 +4,7 @@
 
 Perses helm chart
 
-![Version: 0.1.2](https://img.shields.io/badge/Version-0.1.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.39.0](https://img.shields.io/badge/AppVersion-0.39.0-informational?style=flat-square)
+![Version: 0.1.3](https://img.shields.io/badge/Version-0.1.3-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.39.0](https://img.shields.io/badge/AppVersion-0.39.0-informational?style=flat-square)
 
 ## Installing the Chart
 
@@ -61,10 +61,11 @@ helm delete my-release
 | readinessProbe              | object | `{"enabled":true,"failureThreshold":5,"initialDelaySeconds":5,"periodSeconds":10,"successThreshold":1,"timeoutSeconds":5}`                                                                                                                                                                                                                                 | Readiness probe configuration Ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/                                                                                                                                                                        |
 | replicas                    | int    | `1`                                                                                                                                                                                                                                                                                                                                                        | Number of pod replicas.                                                                                                                                                                                                                                                                                         |
 | resources                   | object | `{}`                                                                                                                                                                                                                                                                                                                                                       | Resource limits & requests. Update according to your own use case as these values might be too low for a typical deployment. ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/                                                                                                |
-| service                     | object | `{"annotations":{},"labels":{},"port":8080,"targetPort":8080,"type":"ClusterIP"}`                                                                                                                                                                                                                                                                          | Expose the Perses service to be accessed from outside the cluster (LoadBalancer service). or access it from within the cluster (ClusterIP service). Set the service type and the port to serve it.                                                                                                              |
+| service                     | object | `{"annotations":{},"labels":{},"port":8080,"portName":"http","targetPort":8080,"type":"ClusterIP"}`                                                                                                                                                                                                                                                        | Expose the Perses service to be accessed from outside the cluster (LoadBalancer service). or access it from within the cluster (ClusterIP service). Set the service type and the port to serve it.                                                                                                              |
 | service.annotations         | object | `{}`                                                                                                                                                                                                                                                                                                                                                       | Annotations to add to the service                                                                                                                                                                                                                                                                               |
 | service.labels              | object | `{}`                                                                                                                                                                                                                                                                                                                                                       | Labeles to add to the service                                                                                                                                                                                                                                                                                   |
 | service.port                | int    | `8080`                                                                                                                                                                                                                                                                                                                                                     | Service Port                                                                                                                                                                                                                                                                                                    |
+| service.portName            | string | `"http"`                                                                                                                                                                                                                                                                                                                                                   | Service Port Name                                                                                                                                                                                                                                                                                               |
 | service.targetPort          | int    | `8080`                                                                                                                                                                                                                                                                                                                                                     | Perses running port                                                                                                                                                                                                                                                                                             |
 | service.type                | string | `"ClusterIP"`                                                                                                                                                                                                                                                                                                                                              | Service Type                                                                                                                                                                                                                                                                                                    |
 | serviceAccount              | object | `{"annotations":{},"create":true,"name":""}`                                                                                                                                                                                                                                                                                                               | Service account for Perses to use.                                                                                                                                                                                                                                                                              |

diff --git a/charts/perses/templates/ingress.yaml b/charts/perses/templates/ingress.yaml
@@ -23,5 +23,5 @@ spec:
           service:
             name: {{ include "perses.fullname" . }}
             port:
-              name: {{ .Values.service.port }}
-{{- end }}
+              name: {{ .Values.service.portName }}
+{{- end }}
diff --git a/charts/perses/values.schema.json b/charts/perses/values.schema.json
@@ -50,6 +50,9 @@
             "ExternalName"
           ]
         },
+	"portName": {
+          "type": "string"
+	},
         "port": {
           "type": "integer"
         },
@@ -59,6 +62,7 @@
       },
       "required": [
         "port",
+        "portName",
         "targetPort",
         "type"
       ]

diff --git a/charts/perses/values.yaml b/charts/perses/values.yaml
@@ -39,6 +39,8 @@ service:
   labels: {}
   # -- Service Type
   type: "ClusterIP"
+  # -- Service Port Name
+  portName: http
   # -- Service Port
   port: 8080
   # -- Perses running port