fix: Ensure that the displayname property is not parsed
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have nodes with number-like names those values might be corrupted. While integer like names would be casted back to string, float-like names would be corrupted. E.g. `2024.10` will be parsed to number `2024.1` thus loosing the trailing 0. Signed-off-by: Ferdinand Thiessen <[email protected]>
8 tasks
perry-mitchell
approved these changes
Sep 7, 2024
|
Would it be possible to create a new patch release for this @perry-mitchell ? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have nodes with number-like names those values might be corrupted. While integer like names would be casted back to string, float-like names would be corrupted.
E.g.
2024.10will be parsed to number2024.1thus loosing the trailing 0.@perry-mitchell I think there might be even more places, especially with custom properties, where the parsing will lead to unexpected behavior. So maybe disable parsing in general and let users parse it?
Or at least expose the preprocessors, so users can decide which prop to parse.
But I think that would be a breaking change so not in 5.x. So this PR only fixes the displayname.