getDirectoryContents returning different and broken result on Windows

[julijane]

The result of getDirectoryContents is broken on Windows.

Sample code:

var webdavClient = require('webdav')
var webdav = webdavClient(
    'https://<redacted>',
    'test',
    '<redacted>'
)
webdav.getDirectoryContents('/test').then(function(contents){
    console.log(contents)
})

Result on Linux:

[ { filename: '/test/testfile',
    basename: 'testfile',
    lastmod: 'Mon, 10 Sep 2018 23:43:40 GMT',
    size: 0,
    type: 'file',
    mime: 'application/octet-stream' },
  { filename: '/test/testfile2',
    basename: 'testfile2',
    lastmod: 'Mon, 10 Sep 2018 23:43:44 GMT',
    size: 0,
    type: 'file',
    mime: 'application/octet-stream' } ]

Result on Windows:

[ { filename: '/test',
    basename: 'test',
    lastmod: 'Mon, 10 Sep 2018 23:43:46 GMT',
    size: 0,
    type: 'directory' },
  { filename: '/test\\testfile',
    basename: 'testfile',
    lastmod: 'Mon, 10 Sep 2018 23:43:40 GMT',
    size: 0,
    type: 'file',
    mime: 'application/octet-stream' },
  { filename: '/test\\testfile2',
    basename: 'testfile2',
    lastmod: 'Mon, 10 Sep 2018 23:43:44 GMT',
    size: 0,
    type: 'file',
    mime: 'application/octet-stream' } ]

So on Windows the full filename is wrong and (partly) using windows path separators, also the containing directory is included in the output on Windows.

This is with webdav 1.5.3 from npm.

[julijane]

Turns out this is easily fixed. I submitted a PR.

[perry-mitchell]

@julijane Thanks! Pathing has really been a huge pain.. Nice that you got it fixed so quickly. I'll merge and release asap.