Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SirTrevorJS admin integration #3

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

SirTrevorJS admin integration #3

wants to merge 17 commits into from

Conversation

meshy
Copy link
Member

@meshy meshy commented Sep 4, 2016

No description provided.

@meshy
Copy link
Member Author

meshy commented Sep 5, 2016

Errors shown in tests:

./tests/test_admin.py:27:1: W391 blank line at end of file
psycopg2.ProgrammingError: type "jsonb" does not exist

To fix the jsonb one, we need to tell Travis to use PostgreSQL 9.4+.

@meshy meshy changed the title Selenium with needle SirTrevorJS admin integration Sep 5, 2016
@meshy
Copy link
Member Author

meshy commented Oct 8, 2016

Rendered images do not match expected images. In the case of the youtube video this is expected, because the youtube background is "TV static", and is not the same on each screenshot. The case of the empty content needs investigation.

Of more concern is how the test build gets stuck on PhantomJS for some reason. While this does seem to happen quite often, I have not yet determined a pattern or cause.

@meshy
Copy link
Member Author

meshy commented Dec 15, 2016

Suddenly obvious way to fix youtube rendering issue... don't use that particular block for the screenshot tests! Use a different block (at least for the moment).

I loathe that we have to log in manually. With a form. Like animals.

FIXME: Find a way to make this work without filling in a form. Just set
a "session" cookie, or something? I tried. I was defeated.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That. Looks. Amazing. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants