-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SirTrevorJS admin integration #3
base: master
Are you sure you want to change the base?
Conversation
It's not got a lot in the way of helper methods yet, but that'll come, I hope.
Errors shown in tests:
To fix the |
Rendered images do not match expected images. In the case of the youtube video this is expected, because the youtube background is "TV static", and is not the same on each screenshot. The case of the empty content needs investigation. Of more concern is how the test build gets stuck on PhantomJS for some reason. While this does seem to happen quite often, I have not yet determined a pattern or cause. |
Suddenly obvious way to fix youtube rendering issue... don't use that particular block for the screenshot tests! Use a different block (at least for the moment). |
I loathe that we have to log in manually. With a form. Like animals. | ||
|
||
FIXME: Find a way to make this work without filling in a form. Just set | ||
a "session" cookie, or something? I tried. I was defeated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you can take some inspiration from https://github.com/aptiko/django-selenium-clean/blob/master/django_selenium_clean/__init__.py#L50, or depend on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That. Looks. Amazing. Thank you!
No description provided.