(many) Add explicitly typed int[] arrays
#496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
commented
Jun 18, 2024
| break; | ||
|
|
||
| case "string" or "String": | ||
| // Perlang String is NOT the same as the .NET String class. | ||
| typeReference.SetClrType(typeof(Lang.String)); | ||
| typeReference.SetClrType(typeReference.IsArray ? typeof(Lang.String[]) : typeof(Lang.String)); |
There was a problem hiding this comment.
The above adds support for many more array types than just int[], but only int[] (implicit and explicit) is supported right now. We'll add int[] and string[] as the two first ones, and the next ones will perhaps go into the next milestone.
perlun
commented
Jun 18, 2024
|
|
||
| result.OutputAsString.Should() | ||
| .Contain("index out of range (3 > 2)"); | ||
| } |
There was a problem hiding this comment.
perlun
force-pushed
the
feature/implement-perlang-arrays
branch
2 times, most recently
from
db72def
to
cd66d05
Compare
perlun
force-pushed
the
feature/implement-perlang-arrays
branch
from
cd66d05
to
a312f25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of #494, but making it possible to declare these explicitly too.