(many) Support string+bigint and bigint+string concatenation #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
added
the
experimental compilation
perlun
commented
May 9, 2024
| @@ -39,7 +59,7 @@ namespace perlang | |||
| ASCIIString::~ASCIIString() | |||
| { | |||
| if (owned_) { | |||
| delete[] bytes_; | |||
| free((void*)bytes_); | |||
There was a problem hiding this comment.
This was an oversight in the old code; it worked but.. mixing malloc and delete isn't really a great idea. Either go with malloc+free or new+delete but never a combination of those. Since we are dealing with plain, C-style char* pointers that we then do memcpy and stuff using, I think C-style allocation makes a bit of sense in this case.
perlun
force-pushed
the
feature/string-and-bigint-concatenation
branch
from
f9246d9
to
dcc0d62
Compare
perlun
commented
May 9, 2024
| memcpy((void*)bytes, str.c_str(), str.length()); | ||
| memcpy((void*)(bytes + str.length()), rhs.bytes(), rhs.length()); | ||
| memcpy(bytes, str.c_str(), str.length()); | ||
| memcpy((bytes + str.length()), rhs.bytes(), rhs.length()); |
There was a problem hiding this comment.
(Removed these void* casts both here and in utf8_string.cc. char* can be implicitly cast to void*, so let's perhaps use that fact to make the code a little bit easier on the reader.
perlun
force-pushed
the
feature/string-and-bigint-concatenation
branch
from
dcc0d62
to
d4ba0d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.