(stdlib) Support ASCII-to-UTF8 string reassignment in compiled mode #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
added
stdlib
perlun
force-pushed
the
feature/support-string-reassignment
branch
from
0dcea42 to
03531da
Compare
perlun
commented
Apr 27, 2024
| @@ -132,7 +132,7 @@ public void division_by_zero_throws_expected_runtime_error() | |||
| [SkippableFact] | |||
| public void division_by_zero_halts_execution() | |||
| { | |||
| Skip.If(PerlangMode.ExperimentalCompilation, "Not supported in compiled mode"); | |||
| Skip.If(PerlangMode.ExperimentalCompilation, "Division by zero has undefined behavior in compiled mode."); | |||
There was a problem hiding this comment.
(Just a drive-by-improvement to make the skip message a bit clearer. We should try to do similarly on all skipped tests, ideally (or better yet, fix them so they are no longer skipped))
perlun
commented
Apr 27, 2024
| // not be reassigned on the second line... because it is constant. We'll have to think through how to solve this | ||
| // properly. | ||
| Skip.If(PerlangMode.ExperimentalCompilation, "Not yet supported in compiled mode"); | ||
|
|
There was a problem hiding this comment.
☝️ This is the only test that didn't work in this test class. The other ones were just a matter of removing the skipping; they would already pass with our current code base.
perlun
force-pushed
the
feature/support-string-reassignment
branch
from
03531da to
1be792f
Compare
perlun
commented
Apr 27, 2024
| output.Should() | ||
| .Be("this is a string"); | ||
| } | ||
|
|
There was a problem hiding this comment.
Added for the sake of completeness. ASCIIString was already doing the right thing, since its from_static_string() was returned a std::shared_ptr<const ASCIIString> return value.
perlun
commented
Apr 27, 2024
|
|
||
| #include "utf8_string.h" | ||
|
|
||
| namespace perlang | ||
| { | ||
| UTF8String UTF8String::from_static_string(const char* s) | ||
| std::shared_ptr<const UTF8String> UTF8String::from_static_string(const char* s) |
There was a problem hiding this comment.
☝️ This is the fix that makes the test work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.