(consoleapp) Remove custom IConsole implementations
#456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation for rewriting the argument handling in Perlang, as one of the very first elements of the compiler to become self-hosted. Regretfully, this means that we will lose some of our test coverage, but we will have to revisit that aspect later.
perlun
commented
Apr 12, 2024
| "help", | ||
| "quit" | ||
| }.Select(s => "/" + s)); | ||
|
|
There was a problem hiding this comment.
No longer used, should rightfully have been removed already in #446.
perlun
commented
Apr 12, 2024
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Losing this whole test is the price we have to pay for removing the IPerlangConsole and related code. 😢 We'll have to live with it for now.
perlun
added a commit
that referenced
this pull request
Apr 12, 2024
This is a preparation for rewriting the argument handling in Perlang, as one of the very first elements of the compiler to become self-hosted. Regretfully, this means that we will lose some of our test coverage, but we will have to revisit that aspect later.
perlun
changed the title
IConsole implementationsIConsole implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for rewriting the argument handling in Perlang, as one of the very first elements of the compiler to become self-hosted. Regretfully, this means that we will lose some of our test coverage, but we will have to revisit that aspect later.