(many) Use Perlang strings and native C functions for writing to stdout #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
force-pushed
the
feature/use-Perlang-strings-in-print-statement
branch
from
790226c to
2fdbb69
Compare
perlun
commented
Apr 22, 2023
| @@ -19,12 +19,14 @@ namespace Perlang.Interpreter.Internals | |||
| /// </summary> | |||
| internal class AstPrinter : Expr.IVisitor<string>, Stmt.IVisitor<string> | |||
| { | |||
| // TODO: Return Perlang string instead | |||
perlun
commented
Apr 22, 2023
| // string as an AsciiString in the created Literal. | ||
| return new Expr.Literal(AsciiString.from(chars)); | ||
| Lang.String nativeString = Lang.String.from(s); | ||
| return new Expr.Literal(nativeString); |
There was a problem hiding this comment.
The code that used to be here was pretty much inlined in String.from, to make it be generically usable from elsewhere.
perlun
commented
Apr 22, 2023
|
|
||
| public void WriteStdoutLine(String s) | ||
| { | ||
| int bytesWritten = Libc.Internal.write(Libc.Internal.STDOUT_FILENO, s.Bytes, (int)s.Length); |
There was a problem hiding this comment.
Interestingly enough, this approach seems to work on both Linux and windows (tested on Windows 10). 😲 If we don't need to write platform-dependent code, we should obviously not be writing platform-dependent code...
(Reading keypresses might be a bigger challenge. We'll get to that eventually, trying to do without Console.ReadKey)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #390 for the over-arching goal.