(tests) Make BinaryOperatorDataTests faster
#332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
added
enhancement
perlun
force-pushed
the
tests/make-BinaryOperatorDataTests-faster
branch
from
623fa46 to
5bb490f
Compare
perlun
changed the title
BinaryOperatorDataTests faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noted lately that some of the tests now take a noticeable time to execute. The fact that commonly used test values like
4294967295was being evaluated over and over again was perhaps good for stress-testing the concurrency handling in the Perlang interpreter 😉 but pretty stupid from any other point of view.Caching these evaluated values brings the execution for these tests down from about ~25s to about 2-3s on my machine, which is a nice small step to retain very fast execution of our test suite.