(interpreter) Make operand type checks be compile-time errors #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
added
enhancement
perlun
commented
May 10, 2022
| @@ -904,6 +904,7 @@ private static void CheckNumberOperands(Token @operator, object? left, object? r | |||
| return; | |||
| } | |||
|
|
|||
| // TODO: Why does this still happen? | |||
| throw new RuntimeError(@operator, $"Operands must be numbers, not {StringifyType(left)} and {StringifyType(right)}"); | |||
There was a problem hiding this comment.
There are still some tests which make assertions on this (runtime) error, which puzzles me a bit. I'll look into this a bit further before getting this merged.
There was a problem hiding this comment.
Ah, I get it now... This is a bit hairy. 🙈 Here's an example test that will trigger this:
fun greet(name: string, age: int): void {
print "Hello " + name + ". Your age is " + age;
}
// Expected warning: [line 6] Warning at 'name': Null parameter detected
greet(null, 42);
The above is understood as string + string, but string + null will cause the exception above. This is not ideal; I filed a new bug about it now: #330.
perlun
force-pushed
the
fix/make-type-checks-validation-errors
branch
from
896274f
to
e71f87d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly improves the developer experience. It involves a bit of duplication, but the duplication is more or less inevitable in this case.