Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data-driven tests for binary operators #231

Closed
9 of 11 tasks
perlun opened this issue Nov 19, 2021 · 3 comments
Closed
9 of 11 tasks

Add data-driven tests for binary operators #231

perlun opened this issue Nov 19, 2021 · 3 comments
Labels
tests This issue is related to unit/integration tests
Milestone
0.2.0

Comments

@perlun
Copy link
Collaborator

perlun commented Nov 19, 2021 •
edited
Loading

#230 added data-driven tests for comparison operators. Similar work could be done elsewhere as well:

Data driven tests with test data for all types currently supported in the language

Non-binary operators which would also be good to cover at some point

  • PostfixDecrement
  • PostfixIncrement
@perlun perlun added the tests This issue is related to unit/integration tests label Nov 19, 2021
@perlun perlun added this to the 0.1.0 milestone Nov 19, 2021
@perlun perlun mentioned this issue Nov 20, 2021
Merged
@perlun perlun modified the milestones: 0.1.0, 0.2.0 Feb 8, 2022
@perlun
Copy link
Collaborator Author

perlun commented Feb 8, 2022

Not blocking the 0.1.0 release. Moving forward.

@perlun
Copy link
Collaborator Author

perlun commented Apr 23, 2022

This has actually been done in #313, even though not all operators have full type coverage yet. I'll use this issue for tracking this now until #316 can be merged (indicating that all type combinations are fully covered for all operators).

@perlun perlun mentioned this issue Apr 23, 2022
Merged
perlun added a commit that referenced this issue Apr 23, 2022
@perlun
(tests) Add full type coverage for += and -= operators (#319)
2af0700 
See #231 for the bigger picture.
perlun added a commit that referenced this issue Apr 24, 2022
@perlun
(tests) Add full type coverage for == and != operators
05740a9 
See #231 for the bigger picture.
perlun added a commit that referenced this issue Apr 24, 2022
@perlun
(tests) Add full type coverage for == and != operators
160d333 
See #231 for the bigger picture.
@perlun perlun mentioned this issue Apr 24, 2022
Merged
perlun added a commit that referenced this issue Apr 24, 2022
@perlun
(tests) Add full type coverage for == and != operators (#320)
719ac2a 
See #231 for the bigger picture.
perlun added a commit that referenced this issue Apr 24, 2022
@perlun
(tests) Add full type coverage for < and <= operators
0e84e01 
See #231 for the bigger picture.
@perlun perlun mentioned this issue Apr 24, 2022
Merged
perlun added a commit that referenced this issue Apr 24, 2022
@perlun
(tests) Add full type coverage for < and <= operators (#321)
0b7e501 
See #231 for the bigger picture.
perlun added a commit that referenced this issue Apr 24, 2022
@perlun
(tests) Add full type coverage for > and >= operators
05938de 
See #231 for the bigger picture.
@perlun perlun mentioned this issue Apr 24, 2022
Merged
perlun added a commit that referenced this issue Apr 24, 2022
@perlun
(tests) Add full type coverage for > and >= operators (#322)
4c728ad 
See #231 for the bigger picture.
perlun added a commit that referenced this issue Apr 24, 2022
@perlun
(tests) Add full type coverage for ** operator
d44ddcd 
See #231 for the bigger picture.
@perlun perlun mentioned this issue Apr 24, 2022
Merged
perlun added a commit that referenced this issue Apr 24, 2022
@perlun
(tests) Add full type coverage for ** operator (#323)
dd7f9dd 
See #231 for the bigger picture.
perlun added a commit that referenced this issue Apr 26, 2022
@perlun
(tests) Add full type coverage for % operator
9e62fd8 
See #231 for the bigger picture.
@perlun perlun mentioned this issue Apr 26, 2022
Merged
perlun added a commit that referenced this issue Apr 27, 2022
@perlun
(tests) Add full type coverage for % operator
665400c 
See #231 for the bigger picture.
perlun added a commit that referenced this issue Apr 27, 2022
@perlun
(tests) Add full type coverage for % operator (#324)
107197e 
See #231 for the bigger picture.
perlun added a commit that referenced this issue Apr 27, 2022
@perlun
(tests) Add full type coverage for << and >> operators
a30d24a 
See #231 for the bigger picture.
@perlun perlun mentioned this issue Apr 27, 2022
Merged
perlun added a commit that referenced this issue Apr 27, 2022
@perlun
(tests) Add full type coverage for << and >> operators (#325)
633b584 
See #231 for the bigger picture.
@perlun
Copy link
Collaborator Author

perlun commented Jun 13, 2022

I think this is accomplished well enough for 0.2.0, so I'll close this now. As for these:

Non-binary operators which would also be good to cover at some point

  • PostfixDecrement
  • PostfixIncrement

...we'll cover them in a separate issue, if/when we decide to do something similar there. (UnaryPostifxOperator test with UnaryPostfixOperatorData or something.)

@perlun perlun closed this as completed Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests This issue is related to unit/integration tests
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@perlun