Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testapp: Dancer request_uri is not decoded #34

Closed
timlegge opened this issue Oct 16, 2021 · 0 comments · Fixed by #37
Closed

testapp: Dancer request_uri is not decoded #34

timlegge opened this issue Oct 16, 2021 · 0 comments · Fixed by #37
Assignees
Labels
bug Something isn't working
Milestone

Comments

@timlegge
Copy link
Contributor

In Dancer request_uri is not decoded and this leads to passing a undecoded uls to the redirect binding of Net::SAML2 which fails to parse properly

@timlegge timlegge self-assigned this Oct 16, 2021
@timlegge timlegge added this to the Version 41 milestone Oct 16, 2021
@timlegge timlegge added the bug Something isn't working label Oct 16, 2021
timlegge added a commit to timlegge/perl-Net-SAML2 that referenced this issue Oct 16, 2021
@timlegge timlegge linked a pull request Oct 17, 2021 that will close this issue
timlegge added a commit to timlegge/perl-Net-SAML2 that referenced this issue Oct 21, 2021
  [Significant Changes since 0.40]

  - COMPATABILITY WARNING: version 0.44 will likely make sha256 the default
  - HTTP-Redirect now supports signing and verifying with more than rsa-sha1
  - include HTTP-Post for SingleLogoutService in generated metadata
  - Destination missing in LogoutRequest
  - Added PingIdentity to the tested IdPs
  - Most other changes related to the testapp Saml2Test (in git repo)

  [Change Log]
  - f694501 testapp: prevent app error if the are no slo_urls
  - c2c9e4b testapp: revert previous change to sls-redirect-response
  - c9532b3 Fixes perl-net-saml2#30 - Modules withou version and cleanup missing Abstract
  - 9c5585b Merge pull request perl-net-saml2#37 from timlegge/testapp
  - c51ba51 Tested compatiblity against PingIdentity
  - b4d3fe9 Remove end of line spaces
  - 41ef582 testapp: provide documentation on how to use the Saml2Test application
  - 5a8ebb7 Fixes perl-net-saml2#36 testapp: metadata is rendered as text by the browser
  - f1e2eca testapp: add .gitignore file testapp
  - ca4b8bd Fixes perl-net-saml2#35: Metadata does not include HTTP-Post for SingleLogoutService
  - 64008da testapp: Better org_name
  - 22073bb Update certificates with 10 year expiration
  - f215c40 testapp: add lightttpd.conf to proxy https traffic to testapp on port 3000
  - f92ba77 testapp: provide lighttpd config to deliver a metatdata.xml file
  - 2d671a4 Fixes perl-net-saml2#32: HTTP-Redirect should support more than sha1
  - 5e2425a testapp: Make required settings configurable
  - f70b0a5 Fixes perl-net-saml2#34: testapp: Dancer request_uri is not decoded
  - 8c0d048 testapp: Fixes perl-net-saml2#33 Destination is not properly assigned
  - 6e0a685 Fixes perl-net-saml2#31 Destination missing in LogoutRequest
  - 652c763 testapp: support post for LogoutResponse
timlegge added a commit to timlegge/perl-Net-SAML2 that referenced this issue Oct 25, 2021
  [Significant Changes since 0.40]

  - COMPATABILITY WARNING: version 0.44 will likely make sha256 the default
  - HTTP-Redirect now supports signing and verifying with more than rsa-sha1
  - include HTTP-Post for SingleLogoutService in generated metadata
  - Destination missing in LogoutRequest
  - Added PingIdentity to the tested IdPs
  - Most other changes related to the testapp Saml2Test (in git repo)

  [Change Log]
  - f694501 testapp: prevent app error if the are no slo_urls
  - c2c9e4b testapp: revert previous change to sls-redirect-response
  - c9532b3 Fixes perl-net-saml2#30 - Modules withou version and cleanup missing Abstract
  - 9c5585b Merge pull request perl-net-saml2#37 from timlegge/testapp
  - c51ba51 Tested compatiblity against PingIdentity
  - b4d3fe9 Remove end of line spaces
  - 41ef582 testapp: provide documentation on how to use the Saml2Test application
  - 5a8ebb7 Fixes perl-net-saml2#36 testapp: metadata is rendered as text by the browser
  - f1e2eca testapp: add .gitignore file testapp
  - ca4b8bd Fixes perl-net-saml2#35: Metadata does not include HTTP-Post for SingleLogoutService
  - 64008da testapp: Better org_name
  - 22073bb Update certificates with 10 year expiration
  - f215c40 testapp: add lightttpd.conf to proxy https traffic to testapp on port 3000
  - f92ba77 testapp: provide lighttpd config to deliver a metatdata.xml file
  - 2d671a4 Fixes perl-net-saml2#32: HTTP-Redirect should support more than sha1
  - 5e2425a testapp: Make required settings configurable
  - f70b0a5 Fixes perl-net-saml2#34: testapp: Dancer request_uri is not decoded
  - 8c0d048 testapp: Fixes perl-net-saml2#33 Destination is not properly assigned
  - 6e0a685 Fixes perl-net-saml2#31 Destination missing in LogoutRequest
  - 652c763 testapp: support post for LogoutResponse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant