Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove MI catalyst plugin, and replace with a placeholder cpanfile #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karenetheridge
Copy link
Member

No description provided.

@karenetheridge karenetheridge marked this pull request as draft April 28, 2023 09:29
@jjn1056
Copy link
Member

jjn1056 commented Apr 28, 2023

+1 from me. @haarg thoughts?

@haarg
Copy link
Member

haarg commented Apr 28, 2023

I definitely would love to remove the use of Module::Install from this dist. I have some concerns about this particular approach.

The primary purpose of the generated Makefile.PL it to list and assist installing prereqs. The secondary purpose is to install the Catalyst application, although I don't know how common that is. Creating a release tarball is probably rather rarely used.

Dist::Zilla, on the other hand, is primarily meant to generate a release tarball. Obviously, it can also give you lists of dependencies or install the release. But its priorities are rather different. Also, Dist::Zilla's compatibility priorities are organized around CPAN authors, where Catalyst apps are more often "users" and less likely to be using the most modern software.

So I think I'd like to see something that is more organized around different priorities. For installing prerequisites, using a cpanfile and including appropriate instructions seems like it could be an adequate solution. For installing, I'm not certain. Possibly generating a cpanfile and a dist.ini that uses it would be good. There aren't any other obviously good "EUMM but not shitty" solutions that exist.

@jjn1056
Copy link
Member

jjn1056 commented Apr 28, 2023

FWIW I use DistZilla with the [Prereqs::FromCPANfile plug-in. That way for day to day and easy use with containers I track dependencies with the cpanfile and install directly with Cpanm but for the two applications I deploy as a tarball I can do that as well

maybe always do a cpanfile and add a switch for dzil.ini?

Honestly a redo of this that creates a basic container would be better. TBH I haven’t used ::Devel in years because I always create a container now.

@karenetheridge
Copy link
Member Author

I think perhaps just adding an empty cpanfile (except for a dep on Catalyst itself), with some references to Dist::Zilla documentation (or [@Git::Starter] might be best? Since the primary usecase is for building an application that won't be cpan-installable, a dist.ini is not going to be useful for that case.

@karenetheridge
Copy link
Member Author

I've replaced the dist.ini with a placeholder cpanfile for now. That can be built on later -- my main goal here is to remove the Module::Install bits :)

@karenetheridge karenetheridge marked this pull request as ready for review April 29, 2023 08:52
@karenetheridge karenetheridge changed the title wip for removing MI catalyst plugin, and replacing with autogenerating dist.ini remove MI catalyst plugin, and replacing with a placeholder cpanfile Apr 29, 2023
@karenetheridge karenetheridge changed the title remove MI catalyst plugin, and replacing with a placeholder cpanfile remove MI catalyst plugin, and replace with a placeholder cpanfile Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants