Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMP final release 0.6.0 #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

IMP final release 0.6.0 #210

wants to merge 1 commit into from

Conversation

c4urself
Copy link

No description provided.

@c4urself c4urself mentioned this pull request May 14, 2020
Closed
tjanez
tjanez reviewed May 14, 2020
View reviewed changes
Copy link

@tjanez tjanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also suggest updating the "⚠️ Current status of this project" part of the README since people will encounter it both, on GitHub and PyPI.

ekohl
ekohl suggested changes May 14, 2020
View reviewed changes
Copy link

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should all code be removed as well? At least the tests are failing now.

@nicoddemus nicoddemus mentioned this pull request May 14, 2020
Closed
3 tasks
@c4urself
Copy link
Author

@ekohl -- we can certainly do that, FWIW I'm not a maintainer on this project, but I can include it in the PR if you are able to merge?

@ekohl
Copy link

ekohl commented May 21, 2020

Looking at my review icon (which is gray rather than green) I think I'm unable to.

@tjanez
Copy link

tjanez commented May 21, 2020

I think we could ask @peritus to review and merge this branch after it's ready.

@peritus
Copy link
Owner

peritus commented May 21, 2020

Sure. Can do that.

@kdeldycke kdeldycke mentioned this pull request Jul 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjanez tjanez tjanez left review comments

@ekohl ekohl ekohl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c4urself @ekohl @tjanez @peritus