Add selectbox for server name #460
Conversation
|
@glensc if this is ok for you I'll try to add tests |
|
Are you able to rebase against current 0.20.x, if so, add row to compatibility matrix that was added to readme in #461 if not, I'll rebase myself and force push its branch |
|
I'll do |
ossinkine
force-pushed
the
select-server-name
branch
3 times, most recently
from
da8f381
to
06618b2
Compare
|
I've added a test for a new searcher functionality and also added a row to the matrix you requested |
README.md
Outdated
| @@ -271,11 +272,13 @@ storage.) | |||
| | Searcher::getAllWatches() | ✓ | ✓ [#435] | | |||
| | Searcher::truncateWatches() | ✓ | ✓ [#435] | | |||
| | Searcher::stats() | ✗ [#305] | ✓ | | |||
| | Searcher::getAllServerNames() | ✓ | ✗ [#460] | | |||
There was a problem hiding this comment.
| | Searcher::getAllServerNames() | ✓ | ✗ [#460] | | |
| | Searcher::getAllServerNames() | ✓ [#460] | ✗ | |
src/Searcher/SearcherInterface.php
Outdated
| /** | ||
| * Get all the known server names. | ||
| * | ||
| * @return array|false array of server names or false if not supported |
There was a problem hiding this comment.
i think array|null is better typing, then you can use ?array as native return type
There was a problem hiding this comment.
I didn't add native type because it's not used in other methods
There was a problem hiding this comment.
please add the type as asked.
current minimum PHP version is 7.2 so all language features compatible with that version can be used.
ossinkine
force-pushed
the
select-server-name
branch
from
06618b2
to
6901f23
Compare
|
@glensc Please review |
ossinkine
force-pushed
the
select-server-name
branch
from
6901f23
to
6a63ccc
Compare
|
@glensc when do you plan to release 0.20.1 to be able to use this feature? |
|
I was hoping someone helps out with automatic releases: |
I've added select box for selecting server name but not just a text field.
I've implemented it for MongoDB only because PDO stores SERVER data in a text field and I have no idea how to select one of parameters from it.
Also an index is required for performance purpose.