Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build turbostat and sst on x86 #29

Closed
wants to merge 1 commit into from
Closed

Conversation

rafaelfolco
Copy link
Contributor

Ignore otherwise.

@rafaelfolco rafaelfolco requested a review from k-rister September 2, 2024 19:33
@rafaelfolco rafaelfolco self-assigned this Sep 2, 2024
Copy link
Contributor

@k-rister k-rister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be doing some kind of architecture check and only building it on an x86 one?

As it is it appears like it will try to build, fail, and then just continue anyway. That wastes time on non x86 architectures and will miss errors on x86.

@rafaelfolco
Copy link
Contributor Author

Shouldn't this be doing some kind of architecture check and only building it on an x86 one?

As it is it appears like it will try to build, fail, and then just continue anyway. That wastes time on non x86 architectures and will miss errors on x86.

I'll try to find a better solution that checks arch.

@rafaelfolco rafaelfolco marked this pull request as draft September 2, 2024 19:42
@rafaelfolco rafaelfolco added the invalid This doesn't seem right label Sep 2, 2024
@k-rister
Copy link
Contributor

k-rister commented Sep 3, 2024

Shouldn't this be doing some kind of architecture check and only building it on an x86 one?
As it is it appears like it will try to build, fail, and then just continue anyway. That wastes time on non x86 architectures and will miss errors on x86.

I'll try to find a better solution that checks arch.

Can it not be something simple like:

if [ "${uname -m)" == "x86_64" ]; then <do stuff>; fi

@atheurer
Copy link
Contributor

atheurer commented Sep 3, 2024

the if [ "${uname -m)" == "x86_64" ] is probably fine, but it makes me wonder if we eventually need arch-specific subsections in the workshop json schema

@k-rister
Copy link
Contributor

k-rister commented Sep 3, 2024

the if [ "${uname -m)" == "x86_64" ] is probably fine, but it makes me wonder if we eventually need arch-specific subsections in the workshop json schema

I think it's definitely something worth exploring. The suggestion I made that you reference was just a near term hack to work around this.

@k-rister
Copy link
Contributor

This is being handled by #30 now.

@k-rister k-rister closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants