Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first step in migrating to registries.json #416

Merged
merged 2 commits into from
Oct 28, 2024
Merged

first step in migrating to registries.json #416

merged 2 commits into from
Oct 28, 2024

Conversation

k-rister
Copy link
Contributor

  • create the registries.json JSON schema

  • add logic to bin/base to create a simple registries.json from the registry data that is loaded from /etc/sysconfig/crucible and verify that it passes schema validation

  • create a backup of /etc/sysconfig/crucible and then remove the legacy registry information from it

  • add logic to bin/base to load the data from registries.json into the existing environment variables that are used by Crucible and Rickshaw (a future change will allow Rickshaw to consume registries.json directly and migrate more config information to it)

  • capture registries.json as part of each run that is made

  • refactor bin/base so that things like container arguments are available when needed (to run the schema validator inside a podman container)

- create the registries.json JSON schema

- add logic to bin/base to create a simple registries.json from the
  registry data that is loaded from /etc/sysconfig/crucible and verify
  that it passes schema validation

- create a backup of /etc/sysconfig/crucible and then remove the
  legacy registry information from it

- add logic to bin/base to load the data from registries.json into the
  existing environment variables that are used by Crucible and
  Rickshaw (a future change will allow Rickshaw to consume
  registries.json directly and migrate more config information to it)

- capture registries.json as part of each run that is made

- refactor bin/base so that things like container arguments are
  available when needed (to run the schema validator inside a podman
  container)
… the formal entry point rather than bypassing it
@k-rister k-rister requested a review from a team October 24, 2024 19:53
@k-rister k-rister marked this pull request as ready for review October 24, 2024 19:53
Copy link
Contributor

@rafaelfolco rafaelfolco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k-rister k-rister merged commit 1f8499e into master Oct 28, 2024
212 checks passed
@k-rister k-rister deleted the dev-kmr branch October 28, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
public/private Handle public/private repos rhel-ai
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants