Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev kmr #102

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Dev kmr #102

merged 1 commit into from
Oct 17, 2023

Conversation

k-rister
Copy link
Contributor

No description provided.

@k-rister
skip explicit crucible service stopping in clean-environment action
529e198 
- sometimes the pre-reqs for calling the crucible command aren't met
  in situations where we want to cleanup

- we are already manually cleaning up using podman commands anyway
  (and they won't have the same pre-req problems)
@k-rister k-rister requested a review from rafaelfolco October 16, 2023 20:39
@k-rister k-rister self-assigned this Oct 16, 2023
@k-rister k-rister merged commit c3f50d4 into main Oct 17, 2023
558 checks passed
@k-rister k-rister deleted the dev-kmr branch October 17, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelfolco rafaelfolco rafaelfolco approved these changes

Assignees

@k-rister k-rister

Labels
None yet
Projects
Crucible Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-rister @rafaelfolco