Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UDF #29 - Query scope #30

Merged
merged 1 commit into from
Jun 23, 2023
Merged

UDF #29 - Query scope #30

merged 1 commit into from
Jun 23, 2023

Conversation

dleadbetter
Copy link
Contributor

This pull request updates the apply_user_defined_sort and search_user_defined methods to scope the user defined fields queries to the current class.

@dleadbetter
UDF #29 - Updating queryable sort and search methods to scope the use…
7679a5f 
…r defined fields query to fields for the current table
@dleadbetter dleadbetter requested a review from camdendotlol June 22, 2023 20:26
@dleadbetter dleadbetter added the v0.1.17 Issues in v0.1.17 label Jun 22, 2023
camdendotlol
camdendotlol approved these changes Jun 22, 2023
View reviewed changes
Copy link

@camdendotlol camdendotlol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

With your instructions I was able to finally reproduce the issue locally and then verify that this PR fixes it.

@dleadbetter dleadbetter merged commit 18e14d2 into master Jun 23, 2023
@dleadbetter dleadbetter deleted the feature/udf29_query_scope branch June 23, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camdendotlol camdendotlol camdendotlol approved these changes

Assignees
No one assigned
Labels
v0.1.17 Issues in v0.1.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dleadbetter @camdendotlol