Allow default sort typesense configuration (#304) #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dleadbetter
reviewed
Dec 6, 2024
| @@ -100,7 +101,8 @@ const createTypesenseAdapter = (config: TypesenseConfig, options = {}) => ( | |||
| geoLocationField: 'coordinates', | |||
| additionalSearchParameters: { | |||
| query_by: config.query_by, | |||
| limit: config.limit || 250 | |||
| limit: config.limit || 250, | |||
| sort_by: `_text_match:desc${config.default_sort ? `,${config.default_sort}:asc` : ''}` | |||
There was a problem hiding this comment.
Does this string interpolation need to be done in both places (here and Peripleo utils)? I believe the TypesenseConfig that gets passed into here will contain the transformed sort_by value from Peripleo utils, not the default_sort config option.
dleadbetter
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Per #304 (see also performant-software/core-data-cloud#323):
_text_match:descis the default if nosort_byis passed; include that as the primary sort, then configured option as the secondary (i.e. the default sort if no text query is entered, and the tiebreaker for equivalent text matches)Questions
default_sort, or should the user have to specify direction?