Fix placemarkers component to handle null geometry #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Update to PR #265 , but now using the updated
PlaceMarkerscomponent. Adds handling to filter out places passed to the component that have nullgeometryfields and thus run the risk of crashing the component.Notes
When I tested this last week it seemed that the null geometry was handled somehow by the
featurefunction imported from@turf/turf, but I must have misinterpreted that somehow because now it seems to be throwing acoordinates must be a numbererror. So hopefully this will fix that issue for real.