Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDC #113 - Place Layers #248

Merged
merged 18 commits into from
Feb 1, 2024
Merged

CDC #113 - Place Layers #248

merged 18 commits into from
Feb 1, 2024

Conversation

dleadbetter
Copy link
Collaborator

This pull request adds the LayerMenu, GeoJsonLayer, and RasterLayer components to support rendering custom layers within a MapDraw component. This pull request also creates the MapControl component to allow creating custom map controls.

This pull request also fixes a bug with the maplibre-gl styles not being applied properly.

Screenshot 2024-01-30 at 12 11 44 PM
Screenshot 2024-01-30 at 12 11 53 PM

Copy link
Member

@jamiefolsom jamiefolsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one license question about a dependency. Looks great.

@@ -12,7 +12,8 @@
"@mapbox/mapbox-gl-draw": "^1.4.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was in there prior to this PR, but is the mapbox-gl-draw license compatible with MIT or BSD?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Looks like mapbox-gl-draw is published under the "ISC License", which is equivalent to the BSD 2-Clause and MIT licenses.

@dleadbetter dleadbetter merged commit 764fda1 into master Feb 1, 2024
1 check passed
@dleadbetter dleadbetter deleted the feature/cdc113_place_layers branch February 1, 2024 13:12
dleadbetter added a commit that referenced this pull request Jul 22, 2024
…erlayLayers component to include "georeference" layer type
dleadbetter added a commit that referenced this pull request Jul 22, 2024
dleadbetter added a commit that referenced this pull request Jul 23, 2024
dleadbetter added a commit that referenced this pull request Jul 23, 2024
dleadbetter added a commit that referenced this pull request Jul 23, 2024
dleadbetter added a commit that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.1.3 Issues in v1.1.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants