Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC #121 - Upgrade dependencies #123

Merged
merged 20 commits into from
Apr 14, 2022
Merged

Conversation

dleadbetter
Copy link
Collaborator

@dleadbetter dleadbetter commented Apr 8, 2022

This pull request makes the following changes:

💥 Breaking Changes

GoogleMap/GooglePlacesSearch

Syntax changes for JSX

// single component

<GoogleScript
  googleMapsApiKey='YOUR_KEY'
>
  <GoogleMap
    ...
  />
</GoogleScript>

<GoogleScript
  googleMapsApiKey='YOUR_KEY'
  libraries={['places']}
>
  <GooglePlacesSearch
    ...
  />
</GoogleScript>
// multiple components

<GoogleScript
  googleMapsApiKey='YOUR_KEY'
  libraries={['places']}
>
  <GooglePlacesSearch
    ...
  />
  <GoogleMap
    ...
  />
</GoogleScript>

@dleadbetter dleadbetter requested a review from jamiefolsom April 8, 2022 13:16
@github-pages github-pages bot temporarily deployed to github-pages April 8, 2022 14:14 Inactive
@github-pages github-pages bot temporarily deployed to github-pages April 8, 2022 14:32 Inactive
@github-pages github-pages bot temporarily deployed to github-pages April 8, 2022 14:40 Inactive
@github-pages github-pages bot temporarily deployed to github-pages April 8, 2022 14:43 Inactive
@github-pages github-pages bot temporarily deployed to github-pages April 8, 2022 14:56 Inactive
@github-pages github-pages bot temporarily deployed to github-pages April 8, 2022 15:10 Inactive
@github-pages github-pages bot temporarily deployed to github-pages April 8, 2022 15:16 Inactive
@github-pages github-pages bot temporarily deployed to github-pages April 8, 2022 15:27 Inactive
@github-pages github-pages bot temporarily deployed to github-pages April 8, 2022 15:44 Inactive
Copy link
Member

@jamiefolsom jamiefolsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great -- the hosted storybook will be super useful!

@jamiefolsom
Copy link
Member

@dleadbetter Question: can we configure the accessibility storybook addon specifically to include WCAG 2.1 level AA? That's the standard we're aiming for in this next project. I see that wcag is in the list, but not sure if it's the level they need. Thanks!

@github-pages github-pages bot temporarily deployed to github-pages April 8, 2022 15:57 Inactive
@github-pages github-pages bot temporarily deployed to github-pages April 8, 2022 16:12 Inactive
@dleadbetter dleadbetter added the release documentation A change in this task should be documented in the next release label Apr 8, 2022
@dleadbetter
Copy link
Collaborator Author

@dleadbetter Question: can we configure the accessibility storybook addon specifically to include WCAG 2.1 level AA? That's the standard we're aiming for in this next project. I see that wcag is in the list, but not sure if it's the level they need. Thanks!

@jamiefolsom - That's a great question. I've updated the Google Doc to include A11y as a separate line item and we'll tackle that as it's own task.

@dleadbetter dleadbetter merged commit 442eb4d into master Apr 14, 2022
@dleadbetter dleadbetter deleted the feature/rc121_upgrade_dependencies branch April 14, 2022 19:44
@dleadbetter dleadbetter added v0.5.1 Issues in v0.5.1 and removed release documentation A change in this task should be documented in the next release labels Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v0.5.1 Issues in v0.5.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants