Skip to content

Commit

Permalink
Addressing PR review
Browse files Browse the repository at this point in the history
  • Loading branch information
lwjameson committed Feb 20, 2024
1 parent 234f4fd commit a941b3b
Show file tree
Hide file tree
Showing 12 changed files with 29 additions and 21 deletions.
6 changes: 3 additions & 3 deletions packages/controlled-vocabulary/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@performant-software/controlled-vocabulary",
"version": "1.1.4-beta.9",
"version": "1.1.4-beta.10",
"description": "A package of components to allow user to configure dropdown elements. Use with the \"controlled_vocabulary\" gem.",
"license": "MIT",
"main": "./build/index.js",
Expand All @@ -12,8 +12,8 @@
"build": "webpack --mode production && flow-copy-source -v src types"
},
"dependencies": {
"@performant-software/semantic-components": "^1.1.4-beta.9",
"@performant-software/shared-components": "^1.1.4-beta.9",
"@performant-software/semantic-components": "^1.1.4-beta.10",
"@performant-software/shared-components": "^1.1.4-beta.10",
"i18next": "^21.9.2",
"semantic-ui-react": "^2.1.2",
"underscore": "^1.13.2"
Expand Down
2 changes: 1 addition & 1 deletion packages/geospatial/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@performant-software/geospatial",
"version": "1.1.4-beta.9",
"version": "1.1.4-beta.10",
"description": "TODO: ADD",
"license": "MIT",
"main": "./build/index.js",
Expand Down
4 changes: 2 additions & 2 deletions packages/semantic-ui/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@performant-software/semantic-components",
"version": "1.1.4-beta.9",
"version": "1.1.4-beta.10",
"description": "A package of shared components based on the Semantic UI Framework.",
"license": "MIT",
"main": "./build/index.js",
Expand All @@ -12,7 +12,7 @@
"build": "webpack --mode production && flow-copy-source -v src types"
},
"dependencies": {
"@performant-software/shared-components": "^1.1.4-beta.9",
"@performant-software/shared-components": "^1.1.4-beta.10",
"@react-google-maps/api": "^2.8.1",
"axios": "^0.26.1",
"i18next": "^19.4.4",
Expand Down
2 changes: 2 additions & 0 deletions packages/semantic-ui/src/components/FacetSlider.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import 'rc-slider/assets/index.css';

.facet-slider > .ui.grid {
margin-top: 0em;
}
Expand Down
4 changes: 0 additions & 4 deletions packages/semantic-ui/src/components/FacetSlider.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ import { Grid } from 'semantic-ui-react';
import Facet, { type Props as FacetProps } from './Facet';
import { type RangeSliderProps } from '../types/InstantSearch';

// This is copied from the rc-slider node_module. SO update if updating versions
// See https://nextjs.org/docs/messages/css-npm
import './rc-slider.css';

import './FacetSlider.css';

type Props = FacetProps & RangeSliderProps;
Expand Down
3 changes: 3 additions & 0 deletions packages/semantic-ui/src/components/LazyDocument.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
@import 'react-pdf/dist/esm/Page/AnnotationLayer.css';
@import 'react-pdf/dist/esm/Page/TextLayer.css';

.lazy-document.ui.segment {
display: inline-block !important;
max-width: 100%;
Expand Down
5 changes: 0 additions & 5 deletions packages/semantic-ui/src/components/LazyDocument.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@ import {
import DownloadButton from './DownloadButton';
import LazyLoader from './LazyLoader';

// These are copied from the react-pdt node_module. This is for NextJS builds
// see https://nextjs.org/docs/messages/css-npm
import './AnnotationLayer.css';
import './TextLayer.css';

import './LazyDocument.css';
import ViewPDFButton from './ViewPDFButton';

Expand Down
12 changes: 12 additions & 0 deletions packages/semantic-ui/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,18 @@ module.exports = configure(__dirname, {
'./react-calendar/dist/Calendar.css$': path.resolve(
__dirname,
'../../node_modules/react-calendar/dist/Calendar.css'
),
'./rc-slider/assets/index.css$': path.resolve(
__dirname,
'../../node_modules/rc-slider/assets/index.css'
),
'./react-pdf/dist/esm/Page/AnnotationLayer.css$': path.resolve(
__dirname,
'../../node_modules/react-pdf/dist/esm/Page/AnnotationLayer.css'
),
'./react-pdf/dist/esm/Page/TextLayer.css$': path.resolve(
__dirname,
'../../node_modules/react-pdf/dist/esm/Page/TextLayer.css'
)
}
},
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@performant-software/shared-components",
"version": "1.1.4-beta.9",
"version": "1.1.4-beta.10",
"description": "A package of shared, framework agnostic, components.",
"license": "MIT",
"main": "./build/index.js",
Expand Down
6 changes: 3 additions & 3 deletions packages/user-defined-fields/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@performant-software/user-defined-fields",
"version": "1.1.4-beta.9",
"version": "1.1.4-beta.10",
"description": "A package of components used for allowing end users to define fields on models. Use with the \"user_defined_fields\" gem.",
"license": "MIT",
"main": "./build/index.js",
Expand All @@ -9,8 +9,8 @@
"build": "webpack --mode production && flow-copy-source -v src types"
},
"dependencies": {
"@performant-software/semantic-components": "^1.1.4-beta.9",
"@performant-software/shared-components": "^1.1.4-beta.9",
"@performant-software/semantic-components": "^1.1.4-beta.10",
"@performant-software/shared-components": "^1.1.4-beta.10",
"i18next": "^21.9.1",
"semantic-ui-react": "^2.1.2",
"underscore": "^1.13.2"
Expand Down
2 changes: 1 addition & 1 deletion packages/visualize/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@performant-software/visualize",
"version": "1.1.4-beta.9",
"version": "1.1.4-beta.10",
"description": "A package of components used for data visualization",
"license": "MIT",
"main": "./build/index.js",
Expand Down
2 changes: 1 addition & 1 deletion react-components.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
"packages/user-defined-fields",
"packages/visualize"
],
"version": "1.1.4-beta.9"
"version": "1.1.4-beta.10"
}

0 comments on commit a941b3b

Please sign in to comment.