You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've just migrated from superlogin to couch-auth, so first thanks for your work creating an up-to-date version of this framework!
Since the way usernames are stored and database names are chosen is differently in couch-auth (key value in user doc and <prefix><user-id> for database name), I think the validation of the username could be less restrictive:
user.ts#L102: I think there would be no problem if a username starts with _
util.ts#L13: I think there would be no problem in allowing usernames with uppercase letters or longer than 16 chars
So my proposal would be to just use a regex like /^[A-Za-z0-9_-]{2,50}$/ or to make it configurable.
The text was updated successfully, but these errors were encountered:
klues
added a commit
to asterics/AsTeRICS-Grid
that referenced
this issue
May 25, 2023
Yeah, the 16 char limitation most likely comes from an early version of CouchDB and superlogin where the username was identical to the database name. Making it configurable via config.ts + providing the current regex as default sounds reasonable to me.
I think I'll implemented that myself + clean up something else in the key - logic.
I've just migrated from
superlogin
tocouch-auth
, so first thanks for your work creating an up-to-date version of this framework!Since the way usernames are stored and database names are chosen is differently in
couch-auth
(key
value in user doc and<prefix><user-id>
for database name), I think the validation of the username could be less restrictive:_
So my proposal would be to just use a regex like
/^[A-Za-z0-9_-]{2,50}$/
or to make it configurable.The text was updated successfully, but these errors were encountered: