Do not alter JsonConvert.DefaultSettings #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JsonConvert.DefaultSettings is a static property of a static class, meaning that it's shared across all consumers of Newtonsoft.Json. That is, potentially used by other assemblies than AzureMapsRestToolkit. Instead, use a local JsonSerializerSettings instance in AzureMapsToolkit.Common,BaseServices.
|
@0xced Thanks, great to solve this issue. Hopefully I get some time soon to work with this library. |
|
hi @perfahlen |
|
@fabich, thanks for reminding me. I'll have a look at it this. Unfortunately I am off this week and will not be able to make a release. Hope next week is good enough for you. I will reach out to community to see if anyone can help admin this repository. |
|
The library changed to using System.Text.Json so it should not be an issue anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JsonConvert.DefaultSettings is a static property of a static class, meaning that it's shared across all consumers of Newtonsoft.Json. That is, potentially used by other assemblies than AzureMapsRestToolkit.
Instead, use a local JsonSerializerSettings instance in AzureMapsToolkit.Common,BaseServices.