updating error message and fixing retry snapshot bug #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prklm10
added
🐛 bug
ninadbstack
reviewed
Nov 22, 2024
src/utils.js
Outdated
| throw error; | ||
| } | ||
| log.warn(`Retrying Story: ${args.snapshotName}`); | ||
| log.warn(`Retrying Story: ${args?.snapshotName}`); |
There was a problem hiding this comment.
Please pass the message from out, this will print incorrect line when withPage errors
ninadbstack
reviewed
Nov 26, 2024
src/utils.js
Outdated
| // Add snapshotName to the error message | ||
| const snapshotName = args?.snapshotName; | ||
| if (snapshotName) { | ||
| error.message = `${error.message} - Snapshot Name: ${snapshotName}`; |
There was a problem hiding this comment.
Shouldnt this be Snapshot name followed by error.message ? wouldnt that make it easy to understand snapshot in case of long error messages ?
There was a problem hiding this comment.
Also the original comment is not handled. THe message should be passed from outside. Considering "Retrying Story" makes no sense if we are opening preview page
There was a problem hiding this comment.
Passed form inside try when attempt number > 0.
test fix test fix test fix test fix test fix test fix
ninadbstack
reviewed
Nov 26, 2024
test/storybook.test.js
Outdated
| @@ -173,12 +173,15 @@ describe('percy storybook', () => { | |||
|
|
|||
| await expectAsync(storybook(['http://localhost:8000'])) | |||
| // message contains the client stack trace | |||
| .toBeRejectedWithError(/^Story Error\n.*\/iframe\.html.*$/s); | |||
| .toBeRejectedWithError(/^Snapshot Name:/s); | |||
There was a problem hiding this comment.
This is incorrect change
There was a problem hiding this comment.
fixed. Snapshot name is getting appended to the error.
ninadbstack
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating error message and fixing retry snapshot bug