✨ Add ability to set percy config after core initialization #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Currently, you can only set config options during core initialization. This makes sense for some config used during start up relating to build creation or the asset discovery browser. However other config options can still be set after start up, such as global snapshot options, certain discovery options, and config options registered by other plugins.
This PR adds a
setConfigmethod which enables merging provided config options with the loaded config options. A local API endpoint is also added which callssetConfigfor post requests but otherwise will return the current config object. ThesetConfigmethod will also normalize and validate config options.