Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPLT_3233: Added CLI Start Time #1686

Merged
merged 7 commits into from
Aug 21, 2024
Merged

PPLT_3233: Added CLI Start Time #1686

merged 7 commits into from
Aug 21, 2024

Conversation

this-is-shivamsingh
Copy link
Contributor

@this-is-shivamsingh this-is-shivamsingh commented Aug 6, 2024 •
edited
Loading

Jira: https://browserstack.atlassian.net/browse/PPLT-3233

Changes:

  • Added cliStartTime when percy server get started first time.

@this-is-shivamsingh this-is-shivamsingh requested a review from a team as a code owner August 6, 2024 14:44
@this-is-shivamsingh this-is-shivamsingh changed the title feat: added cli-start-time in CLI PPLT_3233: Added CLI Start Time Aug 6, 2024
pankaj443
pankaj443 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@pankaj443 pankaj443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@this-is-shivamsingh
Copy link
Contributor Author

  • Small Change
  • Instead of sending Date.now() ( ie. an epoch time), we are now sending the exact UTC date, because epoch time in JS is in millisecond while percy-api consider it in seconds. Therefore there was a date mismatch happening. So we are now sending the exact date only

@this-is-shivamsingh this-is-shivamsingh merged commit 21c64d9 into master Aug 21, 2024
36 checks passed
@this-is-shivamsingh this-is-shivamsingh deleted the PPLT_3233 branch August 21, 2024 11:18
@this-is-shivamsingh this-is-shivamsingh added the ✨ enhancement New feature or request label Aug 21, 2024
@ender700 ender700 mentioned this pull request Oct 19, 2024
Open
@IT21336072 IT21336072 mentioned this pull request Nov 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmay-browserstack chinmay-browserstack chinmay-browserstack approved these changes

@pankaj443 pankaj443 pankaj443 approved these changes

@prklm10 prklm10 prklm10 approved these changes

@Amit3200 Amit3200 Amit3200 approved these changes

@ninadbstack ninadbstack Awaiting requested review from ninadbstack ninadbstack is a code owner automatically assigned from percy/percy-product-reviewers

Assignees
No one assigned
Labels
✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@this-is-shivamsingh @Amit3200 @prklm10 @pankaj443 @chinmay-browserstack