GZIP resources before uploading #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninadbstack
reviewed
Apr 2, 2024
| @@ -589,6 +590,27 @@ describe('PercyClient', () => { | |||
| } | |||
| }); | |||
| }); | |||
|
|
|||
| it('can upload a resource from a local path in GZIP format', async () => { | |||
| process.env.PERCY_GZIP = true; | |||
There was a problem hiding this comment.
this should be moved to before and after block so that it can be cleared after current test.
ninadbstack
reviewed
Apr 2, 2024
| @@ -57,6 +59,50 @@ describe('Discovery', () => { | |||
| await server.close(); | |||
| }); | |||
|
|
|||
| it('gathers resources for a snapshot in GZIP format', async () => { | |||
| process.env.PERCY_GZIP = true; | |||
ninadbstack
approved these changes
Apr 2, 2024
rishigupta1599
pushed a commit
that referenced
this pull request
Apr 3, 2024
* gzip resources before uploading * add env var * Add tests for client.js * Add test for discovery * Use pako in test * Use pako in test * unset env var * unset env var * remove test * Add test * delete process.env.PERCY_GZIP before each it block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://browserstack.atlassian.net/browse/PER-3058
Now we are gziping resources before uploading if PERCY_GZIP env var is set. This is useful in cases where dom resources are greater than 25mb and large payload error is received.