Fixed PXB-2756 - SEGFAUL in tmpdir creation #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://jira.percona.com/browse/PXB-2756 Problem: PXB-2649 postfix - Fix on PXB-2649 was not complete in regards to tmpdir causing failing initialization. Fix: Adjusted code declaring as extern.
There was a problem hiding this comment.
@altmannmarcelo how come our test suite didn't catch this? Can you please try to add one?
satya-bodapati
approved these changes
Apr 28, 2022
|
@satya-bodapati as explained over slack, I've identified an issue on Jenkins that made me overlook these test results. It's fixed now and I can see the reason why the fix was incomplete. All tests passed fine as per jenkins link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PXB-2756
Problem:
PXB-2649 postfix - Fix on PXB-2649 was not complete in regards to
tmpdir causing failing initialization.
Fix:
Adjusted code declaring as extern.