-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-12805 Collstats, indexstats iterate only over collections, not views. #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademidoff
reviewed
Feb 1, 2024
BupycHuk
reviewed
Feb 6, 2024
Summary after required changes:
|
ademidoff
approved these changes
Feb 6, 2024
Co-authored-by: Alex Demidoff <[email protected]>
@ademidoff View could be part of namespace [database-name].[collection/view/index-name] I did refactor (possibility to get collections with/without views) and together with this I changed naming to have it more clear. Please take a look once more. |
ademidoff
approved these changes
Feb 6, 2024
JiriCtvrtka
changed the title
PMM-12805 Collstats iterate only over collections, not views.
PMM-12805 Collstats, indexstats iterate only over collections, not views.
Feb 6, 2024
idoqo
approved these changes
Feb 7, 2024
Co-authored-by: Michael Okoko <[email protected]>
1 task
This was referenced Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12805
FB: Percona-Lab/pmm-submodules#3534