PMM-10072 Filter out profiler collection #589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShashankSinha252
requested review from
tshcherban and
JiriCtvrtka
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
exporter/common.go
Outdated
| var systemDBs = []string{"admin", "config", "local"} //nolint:gochecknoglobals | ||
| var ( | ||
| systemDBs = []string{"admin", "config", "local"} //nolint:gochecknoglobals | ||
| systemCollections = []string{"system.profile"} |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
systemCollections is a global variable (gochecknoglobals)
JiriCtvrtka
approved these changes
Nov 22, 2022
dliakhov
reviewed
Nov 28, 2022
exporter/common.go
Outdated
| return collections, nil | ||
| filteredCollections := []string{} | ||
| for _, collection := range collections { | ||
| if collection == systemCollections[0] { |
There was a problem hiding this comment.
if there is only one element in the systemCollections slice, could we use it as a constant variable?
Or if you plan to add more elements to systemCollections slice later could you please write this code which will work if the slice has two or more elements, but not only one?
dliakhov
reviewed
Nov 28, 2022
exporter/common.go
Outdated
| var ( | ||
| systemDBs = []string{"admin", "config", "local"} //nolint:gochecknoglobals | ||
| systemCollections = []string{"system.profile"} | ||
| ) | ||
|
|
||
| func listCollections(ctx context.Context, client *mongo.Client, database string, filterInNamespaces []string) ([]string, error) { |
There was a problem hiding this comment.
is it possible to add tests for the new behavior of filtering collections?
dliakhov
reviewed
Dec 7, 2022
dliakhov
approved these changes
Dec 7, 2022
|
closing it as it was done in #917 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-10072 Filter out profiler collection for monitoring