-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade gopsutil for Apple silicon mac compatibility of go test #342
Merged
percona-csalguero
merged 2 commits into
percona:main
from
hiroshi:update-gopsutil-for-apple-silicon
Sep 20, 2021
Merged
Upgrade gopsutil for Apple silicon mac compatibility of go test #342
percona-csalguero
merged 2 commits into
percona:main
from
hiroshi:update-gopsutil-for-apple-silicon
Sep 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroshi
changed the title
Update gopsutil for Apple silicon mac compatibility of make test
Update gopsutil for Apple silicon mac compatibility of go test
Sep 19, 2021
denisok
requested review from
a team,
percona-csalguero and
JiriCtvrtka
and removed request for
a team
September 20, 2021 08:43
JiriCtvrtka
approved these changes
Sep 20, 2021
percona-csalguero
approved these changes
Sep 20, 2021
percona-csalguero
changed the title
Update gopsutil for Apple silicon mac compatibility of go test
Upgrade gopsutil for Apple silicon mac compatibility of go test
Sep 20, 2021
Online tests are passing and also locally:
|
Thank you for accepting this change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from #295 (comment)
This will fix Apple silicon mac imcompatibility issue of go test.
Update jira ticket description if needed.Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.When all checks have passed and code is ready for the review, bot should add
pmm-review-exporters
team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forums and Discord.