-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replSetGetConfigCollector #295
Merged
Merged
Changes from 26 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
31dca05
replSetGetConfigCollector. it just works
hiroshi ff968d7
Use member_idx for host field to match with replStatus
hiroshi 0837f71
Add --disable.replicasetconfig option flag
hiroshi 3bab659
Merge branch 'main' into replSetGetConfigCollector
hiroshi 03c4922
Merge branch 'main' into replSetGetConfigCollector
JiriCtvrtka c5ba8b6
Merge branch 'main' into replSetGetConfigCollector
denisok f38e30b
Merge branch 'main' into replSetGetConfigCollector
JiriCtvrtka 296e11b
Merge branch 'main' into replSetGetConfigCollector
JiriCtvrtka be17763
Merge branch 'main' into replSetGetConfigCollector
hiroshi 54ded8c
Use errors.As() instead of type assertion.
hiroshi 22b9fe3
Add replset_config_collector_test.
hiroshi 678e125
Revert "Use errors.As() instead of type assertion."
hiroshi bb9ecc8
nolint - errors.As seems to cause segfault.
hiroshi bd5ca57
Merge remote-tracking branch 'origin/main' into replSetGetConfigColle…
hiroshi 529c27c
Merge branch 'main' into replSetGetConfigCollector
BupycHuk 1b2fe08
Update exporter/replset_config_collector.go
BupycHuk dc4899c
Update exporter/replset_config_collector_test.go
BupycHuk 22cf389
Update exporter/replset_config_collector.go
BupycHuk 8d051b0
Update exporter/replset_config_collector_test.go
BupycHuk ec5c37a
Update exporter/replset_config_collector.go
BupycHuk f5b0c15
Update exporter/exporter.go
BupycHuk 58da23b
Update exporter/exporter.go
BupycHuk 75ecc85
Update exporter/replset_config_collector_test.go
BupycHuk 6578e64
Update replset_config_collector.go
BupycHuk 0857d3d
Update replset_config_collector_test.go
BupycHuk 08d54d2
Update exporter/replset_config_collector_test.go
BupycHuk 12469dd
Update exporter/replset_config_collector.go
BupycHuk d4c588d
Update replset_config_collector.go
BupycHuk 36c5423
Merge branch 'main' into replSetGetConfigCollector
BupycHuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
// mongodb_exporter | ||
// Copyright (C) 2017 Percona LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package exporter | ||
|
||
import ( | ||
"context" | ||
|
||
"github.com/pkg/errors" | ||
"github.com/prometheus/client_golang/prometheus" | ||
"github.com/sirupsen/logrus" | ||
"go.mongodb.org/mongo-driver/bson" | ||
"go.mongodb.org/mongo-driver/mongo" | ||
) | ||
|
||
// const ( | ||
// replicationNotEnabled = 76 | ||
// replicationNotYetInitialized = 94 | ||
// ) | ||
BupycHuk marked this conversation as resolved.
Show resolved
Hide resolved
BupycHuk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
type replSetGetConfigCollector struct { | ||
ctx context.Context | ||
base *baseCollector | ||
|
||
compatibleMode bool | ||
topologyInfo labelsGetter | ||
} | ||
|
||
// newReplicationSetConfigCollector creates a collector for configuration of replication set. | ||
func newReplicationSetConfigCollector(ctx context.Context, client *mongo.Client, logger *logrus.Logger, compatible bool, topology labelsGetter) *replSetGetConfigCollector { | ||
return &replSetGetConfigCollector{ | ||
ctx: ctx, | ||
base: newBaseCollector(client, logger.WithFields(logrus.Fields{"collector": "replset_config"})), | ||
|
||
compatibleMode: compatible, | ||
topologyInfo: topology, | ||
} | ||
} | ||
|
||
func (d *replSetGetConfigCollector) Describe(ch chan<- *prometheus.Desc) { | ||
d.base.Describe(d.ctx, ch, d.collect) | ||
} | ||
|
||
func (d *replSetGetConfigCollector) Collect(ch chan<- prometheus.Metric) { | ||
d.base.Collect(ch) | ||
} | ||
|
||
func (d *replSetGetConfigCollector) collect(ch chan<- prometheus.Metric) { | ||
defer measureCollectTime(ch, "mongodb", "replset_config")() | ||
|
||
logger := d.base.logger | ||
client := d.base.client | ||
|
||
cmd := bson.D{{Key: "replSetGetConfig", Value: "1"}} | ||
res := client.Database("admin").RunCommand(d.ctx, cmd) | ||
|
||
var m bson.M | ||
|
||
if err := res.Decode(&m); err != nil { | ||
if e, ok := err.(mongo.CommandError); ok { //nolint // https://github.com/percona/mongodb_exporter/pull/295#issuecomment-922874632 | ||
if e.Code == replicationNotYetInitialized || e.Code == replicationNotEnabled { | ||
return | ||
} | ||
} | ||
logger.Errorf("cannot get replSetGetConfig: %s", err) | ||
|
||
return | ||
} | ||
|
||
config, ok := m["config"].(bson.M) | ||
if !ok { | ||
err := errors.Wrapf(errUnexpectedDataType, "%T for data field", m["config"]) | ||
logger.Errorf("cannot decode getDiagnosticData: %s", err) | ||
|
||
return | ||
} | ||
m = config | ||
|
||
logger.Debug("replSetGetConfig result:") | ||
debugResult(logger, m) | ||
ademidoff marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
for _, metric := range makeMetrics("rs_cfg", m, d.topologyInfo.baseLabels(), d.compatibleMode) { | ||
ch <- metric | ||
} | ||
} | ||
|
||
var _ prometheus.Collector = (*replSetGetConfigCollector)(nil) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
// mongodb_exporter | ||
// Copyright (C) 2017 Percona LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package exporter | ||
|
||
import ( | ||
"context" | ||
"strings" | ||
"testing" | ||
"time" | ||
|
||
"github.com/prometheus/client_golang/prometheus/testutil" | ||
"github.com/sirupsen/logrus" | ||
"github.com/stretchr/testify/assert" | ||
|
||
"github.com/percona/mongodb_exporter/internal/tu" | ||
) | ||
|
||
func TestReplsetConfigCollector(t *testing.T) { | ||
ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second) | ||
defer cancel() | ||
|
||
client := tu.DefaultTestClient(ctx, t) | ||
|
||
ti := labelsGetterMock{} | ||
|
||
c := newReplicationSetConfigCollector(ctx, client, logrus.New(), false, ti) | ||
|
||
// The last \n at the end of this string is important | ||
expected := strings.NewReader(` | ||
# HELP mongodb_rs_cfg_protocolVersion rs_cfg. | ||
# TYPE mongodb_rs_cfg_protocolVersion untyped | ||
mongodb_rs_cfg_protocolVersion 1` + "\n") | ||
// Filter metrics for 2 reasons: | ||
// 1. The result is huge | ||
// 2. We need to check against know values. Don't use metrics that return counters like uptime | ||
// or counters like the number of transactions because they won't return a known value to compare | ||
filter := []string{ | ||
"mongodb_rs_cfg_protocolVersion", | ||
} | ||
err := testutil.CollectAndCompare(c, expected, filter...) | ||
assert.NoError(t, err) | ||
} | ||
|
||
func TestReplsetConfigCollectorNoSharding(t *testing.T) { | ||
ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second) | ||
defer cancel() | ||
|
||
client := tu.TestClient(ctx, tu.MongoDBStandAlonePort, t) | ||
|
||
ti := labelsGetterMock{} | ||
|
||
c := newReplicationSetConfigCollector(ctx, client, logrus.New(), false, ti) | ||
|
||
// Replication set metrics should not be generated for unsharded server | ||
count := testutil.CollectAndCount(c) | ||
|
||
metaMetricCount := 1 | ||
assert.Equal(t, metaMetricCount, count, "Mismatch in metric count for collector run on unsharded server") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we keeping this for purpose?