Add shard label in collstats metrics

percona · Nov 1, 2024 · 0b97543 · 0b97543
1 parent deaf106
commit 0b97543
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/exporter/collstats_collector.go b/exporter/collstats_collector.go
@@ -138,6 +138,10 @@ func (d *collstatsCollector) collect(ch chan<- prometheus.Metric) {
 		labels["collection"] = collection
 
 		for _, metrics := range stats {
+			if shard, ok := metrics["shard"].(string); ok {
+				labels["shard"] = shard
+			}
+
 			for _, metric := range makeMetrics(prefix, metrics, labels, d.compatibleMode) {
 				ch <- metric
 			}

diff --git a/exporter/collstats_collector_test.go b/exporter/collstats_collector_test.go
@@ -59,19 +59,19 @@ func TestCollStatsCollector(t *testing.T) {
 	expected := strings.NewReader(`
 # HELP mongodb_collstats_latencyStats_commands_latency collstats.latencyStats.commands.
 # TYPE mongodb_collstats_latencyStats_commands_latency untyped
-mongodb_collstats_latencyStats_commands_latency{collection="testcol_00",database="testdb"} 0
-mongodb_collstats_latencyStats_commands_latency{collection="testcol_01",database="testdb"} 0
-mongodb_collstats_latencyStats_commands_latency{collection="testcol_02",database="testdb"} 0
+mongodb_collstats_latencyStats_commands_latency{collection="testcol_00",database="testdb",shard="rs1"} 0
+mongodb_collstats_latencyStats_commands_latency{collection="testcol_01",database="testdb",shard="rs1"} 0
+mongodb_collstats_latencyStats_commands_latency{collection="testcol_02",database="testdb",shard="rs1"} 0
 # HELP mongodb_collstats_latencyStats_transactions_ops collstats.latencyStats.transactions.
 # TYPE mongodb_collstats_latencyStats_transactions_ops untyped
-mongodb_collstats_latencyStats_transactions_ops{collection="testcol_00",database="testdb"} 0
-mongodb_collstats_latencyStats_transactions_ops{collection="testcol_01",database="testdb"} 0
-mongodb_collstats_latencyStats_transactions_ops{collection="testcol_02",database="testdb"} 0
+mongodb_collstats_latencyStats_transactions_ops{collection="testcol_00",database="testdb",shard="rs1"} 0
+mongodb_collstats_latencyStats_transactions_ops{collection="testcol_01",database="testdb",shard="rs1"} 0
+mongodb_collstats_latencyStats_transactions_ops{collection="testcol_02",database="testdb",shard="rs1"} 0
 # HELP mongodb_collstats_storageStats_capped collstats.storageStats.
 # TYPE mongodb_collstats_storageStats_capped untyped
-mongodb_collstats_storageStats_capped{collection="testcol_00",database="testdb"} 0
-mongodb_collstats_storageStats_capped{collection="testcol_01",database="testdb"} 0
-mongodb_collstats_storageStats_capped{collection="testcol_02",database="testdb"} 0` +
+mongodb_collstats_storageStats_capped{collection="testcol_00",database="testdb",shard="rs1"} 0
+mongodb_collstats_storageStats_capped{collection="testcol_01",database="testdb",shard="rs1"} 0
+mongodb_collstats_storageStats_capped{collection="testcol_02",database="testdb",shard="rs1"} 0` +
 		"\n")
 
 	// Filter metrics for 2 reasons: