add Database, MySQLDatabase, and PostgresDatabase to __init__.py #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitrylukashov
approved these changes
May 5, 2020
ddldump/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from .main import Database, MySQLDatabase, PostgresDatabase | |||
There was a problem hiding this comment.
If both MysqlDatabase and PostgresDatabaseinherit fromDatabase` do you need to import the base class?
There was a problem hiding this comment.
removed the base class
chhsiung
force-pushed
the
share-database-classes
branch
from
1dfaeba
to
d1a2ab6
Compare
chhsiung
force-pushed
the
share-database-classes
branch
from
ce0dc1b
to
82fe900
Compare
dimitrylukashov
requested changes
May 6, 2020
| @@ -22,6 +22,9 @@ commands: | |||
| pip: | |||
| type: string | |||
| steps: | |||
| - run: | |||
| name: Install dependencies | |||
| command: << parameters.pip >> install -r requirements.txt | |||
There was a problem hiding this comment.
As discussed, this should not be merged.
Both the packaging (https://packaging.python.org/tutorials/packaging-projects/#generating-distribution-archives) and setuptools docs (https://setuptools.readthedocs.io/en/latest/setuptools.html) recommend updating setuptools and wheels first.
| @@ -22,6 +22,9 @@ commands: | |||
| pip: | |||
| type: string | |||
| steps: | |||
| - run: | |||
| name: Install dependencies | |||
| command: << parameters.pip >> install -r requirements.txt | |||
| - run: | |||
| name: Package the repo into a wheel | |||
| command: << parameters.python >> setup.py bdist_wheel | |||
There was a problem hiding this comment.
This may need an sdist command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.