-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json tree #234
Open
ljack
wants to merge
19
commits into
perak:master
Choose a base branch
from
ljack:json-tree
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Json tree #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work. Some polishing maybe needed later on.
…ok and smoothly in browser too.
@ljack thank you dude! Btw, let's talk privatelly. Can you join me in this repo's gitter chat? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes object-tree selection lost problem.
Adds json-tree to "Edit Source"
Adds syncing between json-tree and json-editor. Select something in json-tree and it will be highlighted in json-editor.
Notice: Needs ecmascript package in production mode, because ES5/6 feature ( x=> {}} used. This can be converted back to normal javascript function callback ;)
You can try this version in https://pim-ljack1.c9.io/ (when it's not down ;)
TODO
Find out why json-tree gets blanked when saving in json-editor. Current fix is to reload page. Which is slow and you loose focus/location in json-editor / json-tree too, which kinda scks.