Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper functions for OAUTH2 authentication (#109) #111

Merged
merged 5 commits into from
Sep 19, 2022
Merged

Conversation

jason-p-pickering
Copy link
Collaborator

  • Add token to d2Session object

  • Add OAUTH login function

  • Update NAMESPACE

  • Documentation and cleanup

  • Update rocker verse R version

  • Update lock

  • Minor

  • Fix R6 import

  • Linting

  • Add lintr to suggests

* Add token to d2Session object

* Add OAUTH login function

* Update NAMESPACE

* Documentation and cleanup

* Update rocker verse R version

* Update lock

* Minor

* Fix R6 import

* Linting

* Add lintr to suggests
@jason-p-pickering
Copy link
Collaborator Author

@JordanBalesBAO or @sam-bao ...any objections to me proceeding to merge the OAUTH stuff into master?

@sam-bao
Copy link
Collaborator

sam-bao commented Sep 19, 2022

@JordanBalesBAO @jason-p-pickering no specific blockers from me. I would probably increment the version to 0.6.0 since this is a major new feature. Jordan is closer to this now and should provide the full review.

I did just add a ticket to update datapackr's lock file to the version of datimutils with the OAUTH work (https://jira.pepfar.net/browse/DP-782). It seems good practice to keep the datapackr and app dependencies roughly synchronized.

@jason-p-pickering
Copy link
Collaborator Author

Thanks @sam-bao . I bumped the version now. @JordanBalesBAO has previously provided his technical review here.

@JordanBalesBAO if you are OK with everything, please approve here as well, and I can proceed with updating the app code.

Copy link
Contributor

@JordanBalesBAO JordanBalesBAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree adding the token to the overall structure of the R6 object is a good idea.

@jason-p-pickering jason-p-pickering merged commit 3346fae into master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants