Dp 781 #110
Merged
Dp 781 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added exceptions for dataSet requirement to allow for dataElementGroup - added exceptions for orgUnit requirement to allow for orgUnitGroup
-changed values to scalar operators
sam-bao
requested changes
Sep 7, 2022
- updated error message - updated test coverage to cover both error changes
|
@sam-bao , updated the error messages to include the new condition and updated testing to cover both messages. Let me know if this suffices. |
sam-bao
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getDataValueSetshas been deprecated fromdatapackr,datimutils::getDataValueSetswas altered to allow passing only adataElementGroupas well as anorgUnitGroup