Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx to v1.25.0 #9

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

windyakin
Copy link
Member

No description provided.

@windyakin
Copy link
Member Author

現状で mruby をビルドすると以下のようなエラーがでるようになった。

#8 24.00 gcc -std=gnu99 -g -O3 -Wall -Wundef -Werror-implicit-function-declaration -Wwrite-strings -fPIC -std=c99 -c -O3 -fPIC   -Wall -Wextra -Werror -Wstrict-prototypes -Wwrite-strings -Wno-missing-field-initializers -g -ggdb  -pedantic test.c
#8 24.00 test.c: In function 'millisleep':
#8 24.00 test.c:81:5: error: "_MSC_VER" is not defined, evaluates to 0 [-Werror=undef]
#8 24.00    81 | #if _MSC_VER
#8 24.00       |     ^~~~~~~~
#8 24.00 cc1: all warnings being treated as errors
#8 24.00 make[1]: *** [Makefile:270: test.o] Error 1
#8 24.00 make[1]: Leaving directory '/usr/local/src/ngx_mruby/mruby/build/host/mrbgems/mruby-redis/hiredis'
#8 24.00 rake aborted!
#8 24.00 make failed

該当部分のコードは以下。

https://github.com/redis/hiredis/blob/ded32c7d1a449a94b0241270342cb75696c64224/test.c#L79-L86

_MSC_VER とは Microsoft C/C++ compiler を使ったときに使えるマクロで、これが GCC だと定義されておらずエラーになっているという状態に見える。

refs: https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170

おそらく直近で入った -Werror をデフォルトにする対応で、該当部分がエラーになるようになったと推測される。

redis/hiredis#1193

というわけで該当部分を修正するためのコードをPRにして出すことにした。

redis/hiredis#1194

@windyakin windyakin merged commit c506da7 into master Jun 9, 2023
@windyakin windyakin deleted the windyakin_20230524_4b234294a7 branch June 9, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant