Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a logger warning otherwise it's not displayed properly. #200

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

ewjoachim
Copy link
Contributor

Also move the warning to the correct location

Successful PR Checklist:

  • Tests (units, integration, 100% coverage)
    • (not applicable?)
  • Documentation
    • (not applicable?)
  • Had a good time contributing?

Also move the warning to the correct location
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #200 (6d6fbad) into master (a458826) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #200   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          980       979    -1     
  Branches       128       128           
=========================================
- Hits           980       979    -1     
Impacted Files Coverage Δ
vault_cli/client.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a458826...6d6fbad. Read the comment docs.

@ewjoachim ewjoachim merged commit bbb4b5f into master Oct 18, 2021
@ewjoachim ewjoachim deleted the warning branch October 18, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants